<html>
<head><meta charset="utf-8"><title>feature gating issue · wg-async-foundations · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/index.html">wg-async-foundations</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html">feature gating issue</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="163677028"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163677028" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Taylor Cramer <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163677028">(Apr 18 2019 at 18:24)</a>:</h4>
<p><span class="user-mention" data-user-id="121053">@varkor</span> did I see that you were working on a fix to the feature gating bug?</p>



<a name="163677058"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163677058" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163677058">(Apr 18 2019 at 18:25)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/60088" target="_blank" title="https://github.com/rust-lang/rust/pull/60088">https://github.com/rust-lang/rust/pull/60088</a></p>



<a name="163677315"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163677315" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163677315">(Apr 18 2019 at 18:27)</a>:</h4>
<p>taking a look</p>



<a name="163677835"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163677835" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163677835">(Apr 18 2019 at 18:32)</a>:</h4>
<p><span class="user-mention" data-user-id="121053">@varkor</span> looks good to me, you can r? me if you like</p>



<a name="163677866"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163677866" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163677866">(Apr 18 2019 at 18:32)</a>:</h4>
<p>or Taylor can do it... :P</p>



<a name="163677870"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163677870" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163677870">(Apr 18 2019 at 18:33)</a>:</h4>
<p><span class="user-mention" data-user-id="126931">@centril</span>: feel free to review it</p>



<a name="163677894"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163677894" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163677894">(Apr 18 2019 at 18:33)</a>:</h4>
<p>it's a straightforward change, so I don't think there are any subtleties</p>



<a name="163677897"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163677897" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163677897">(Apr 18 2019 at 18:33)</a>:</h4>
<p><span class="user-mention" data-user-id="121053">@varkor</span> already reviewed ;)</p>



<a name="163677953"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163677953" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163677953">(Apr 18 2019 at 18:33)</a>:</h4>
<p>haha, bors did not like that</p>



<a name="163677964"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163677964" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163677964">(Apr 18 2019 at 18:34)</a>:</h4>
<p><span class="user-mention" data-user-id="127859">@Taylor Cramer</span> btw, if you do <code>r+</code> you don't need to also <code>r=@cramertj</code></p>



<a name="163678027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163678027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163678027">(Apr 18 2019 at 18:34)</a>:</h4>
<p>just write: <code>r? @cramertj @bors r+</code></p>



<a name="163678068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163678068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163678068">(Apr 18 2019 at 18:34)</a>:</h4>
<p><span class="user-mention" data-user-id="121053">@varkor</span> did you test this locally?</p>



<a name="163678095"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163678095" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163678095">(Apr 18 2019 at 18:35)</a>:</h4>
<p>yes; it passes all UI tests locally</p>



<a name="163678104"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163678104" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163678104">(Apr 18 2019 at 18:35)</a>:</h4>
<p>OK; rolling up then</p>



<a name="163678753"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/feature%20gating%20issue/near/163678753" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Taylor Cramer <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/feature.20gating.20issue.html#163678753">(Apr 18 2019 at 18:40)</a>:</h4>
<p><span class="user-mention" data-user-id="126931">@centril</span> yeah, I typo'd and wrote <code>r=</code> instead of <code>r?</code></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>